Fix the semicolon semantics for indexes while respecting other bug fix. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
reviewed
May 15, 2024
mikealfare
approved these changes
May 15, 2024
|
FYI @VersusFacit - We need to backport this fix for inclusion in v1.7.x + v1.8.x, because this was a regression introduced in v1.7.14. I don't believe we have the backport workflow set up in this repo yet, so we either need to backport manually or set up that workflow. |
2 tasks
mikealfare
pushed a commit
that referenced
this pull request
May 21, 2024
…x. (#97) Co-authored-by: Mila Page <[email protected]> (cherry picked from commit e23d0a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #85
docs dbt-labs/docs.getdbt.com/#
Problem
Reprex now added as test and replicated locally!
@mikealfare shared this lovely context, re the comment linked in the issue ticket (here). We removed a
;at thepostgres__get_create_index_sqlmacro to solve a different problem sending up empty queries when getting this merged:This however was incomplete as a solution because we needed to only leave off the last
;from various index create/alter statements.Solution
Checklist